Skip to main content

C# coding standards and best programming practices

Anybody can write code. With a few months of programming experience, you can write 'working applications'. Making it work is easy, but doing it the right way requires more work, than just making it work.

Introduction

Believe it, majority of the programmers write 'working code', but not ‘good code'. Writing 'good code' is an art and you must learn and practice it.Everyone may have different definitions for the term ‘good code’. In my definition, the following are the characteristics of good code.

 · Reliable
 · Maintainable
 · Efficient

Most of the developers are inclined towards writing code for higher performance, compromising reliability and maintainability. But considering the long term ROI (Return on Investment), efficiency and performance comes below reliability and maintainability. If your code is not reliable and maintainable, you (and your company) will be spending lot of time to identify issues, trying to understand code etc throughout the life of your application.

Purpose of coding standards and best practices

To develop reliable and maintainable applications, you must follow coding standards and best practices.

The naming conventions, coding standards and best practices described in this document are compiled from our own experience and by referring to various Microsoft and non Microsoft guidelines.

There are several standards exists in the programming industry. None of them are wrong or bad and you may follow any of them. What is more important is, selecting one standard approach and ensuring that everyone is following it.

Naming Conventions and standards

Note :
The terms Pascal Casing and Camel Casing are used throughout this document.
Pascal Casing - First character of all words are Upper Case and other characters are lower case.
Example: BackColor
Camel Casing - First character of all words, except the first word are Upper Case and other characters are lower case.
Example: backColor
1. Use Pascal casing for Class names
public class HelloWorld
{
            ...
}
2. Use Pascal casing for Method names
void SayHello(string name)
{
            ...
}
3. Use Camel casing for variables and method parameters
int totalCount=0;
void SayHello(string name)
{
           string fullMessage = "Hello " + name;
            ...
}
4. Use the prefix “I” with Camel Casing for interfaces ( Example: IEntity )

5. Do not use Hungarian notation to name variables.
In earlier days most of the programmers liked it - having the data type as a prefix for the variable name and using m_ as prefix for member variables. Eg:

string m_sName;
int nAge;
However, in .NET coding standards, this is not recommended. Usage of data type and m_ to represent member variables should not be used. All variables should use camel casing.

Some programmers still prefer to use the prefix m_ to represent member variables, since there is no other easy way to identify a member variable.
6. Use Meaningful, descriptive words to name variables. Do not use abbreviations.

Good:

string address
int salary

Not Good:

string nam
string addr
int sal


7. Do not use single character variable names like i, n, s etc. Use names like index, temp.

One exception in this case would be variables used for iterations in loops:
for ( int i = 0; i < count; i++ )
{
            ...
}
If the variable is used only as a counter for iteration and is not used anywhere else in the loop, many people still like to use a single char variable (i) instead of inventing a different suitable name.

8. Do not use underscores (_) for local variable names.

9. All member variables must be prefixed with underscore (_) so that they can be identified from other local variables.

10. Do not use variable names that resemble keywords.

11. Prefix boolean variables, properties and methods with “is” or similar prefixes.

Ex:
private bool _isFinished

12. Namespace names should follow the standard pattern

...

13. Use appropriate prefix for the UI elements so that you can identify them from the rest of the variables.

     There are 2 different approaches recommended here.

           a. Use a common prefix ( ui_ ) for all UI elements. This will help you group all of the UI elements together and easy to access all of them from the intelligence.

           b. Use appropriate prefix for each of the ui element. A brief list is given below. Since .NET has given several controls, you may have to arrive at a complete list of standard prefixes for each of the controls (including third party controls) you are using.

Control
Prefix
Label
lbl
TextBox
txt
DataGrid
dtg
Button
btn
ImageButton
imb
Hyperlink
hlk
DropDownList
ddl
ListBox
lst
DataList
dtl
Repeater
rep
Checkbox
chk
CheckBoxList
cbl
RadioButton
rdo
RadioButtonList
rbl
Image
img
Panel
pnl
PlaceHolder
phd
Table
tbl
Validators
val


14. File name should match with class name.

For example, for the class HelloWorld, the file name should be helloworld.cs (or, helloworld.vb)

15. Use Pascal Case for file names.

Good:

// Format a message and display

string fullMessage = "Hello " + name; DateTime currentTime = DateTime.Now; string message = fullMessage + ", the time is : " + currentTime.ToShortTimeString(); MessageBox.Show ( message );

Not Good:

// Format a message and display string fullMessage = "Hello " + name; DateTime currentTime = DateTime.Now; string message = fullMessage + ", the time is : " + currentTime.ToShortTimeString(); MessageBox.Show ( message );


3. Curly braces ( {} ) should be in the same level as the code outside the braces.



4. Use one blank line to separate logical groups of code.

Good:
              bool SayHello ( string name )
             {
                      string fullMessage = "Hello " + name;
                      DateTime currentTime = DateTime.Now;

                      string message = fullMessage + ", the time is : " + currentTime.ToShortTimeString();

               MessageBox.Show ( message );

               if ( ... )
               {
                    // Do something
                    // ...
                    return false;
               }

               return true;
             }


Not Good:

    
bool SayHello (string name)
    {
      string fullMessage = "Hello " + name;
      DateTime currentTime = DateTime.Now;
      string message = fullMessage + ", the time is : " + currentTime.ToShortTimeString();
      MessageBox.Show ( message );
      if ( ... )
      {
           // Do something
           // ...
           return false;
      }
      return true;
    }


5. There should be one and only one single blank line between each method inside the class.

6. The curly braces should be on a separate line and not in the same line as if, for etc.

Good:

    
if ( ... )
    {
      // Do something
    }


Not Good:

    
if ( ... ) {
            // Do something
    }


7. Use a single space before and after each operator and brackets.

Good:
    
if ( showResult == true )
    {
      for ( int i = 0; i < 10; i++ )
      {            //
      }
    }


Not Good:
    
if(showResult==true)
    {
      for(int i= 0;i<10 br="" i="">            {
              //
           }
    }


Comments